Hello shimoda-san,
Thanks for point out checkpatch warning. After resolving checkpatch warning,
below checkpatch warning is seen.
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per
line)
#23:
[1] commit f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code")
is this warning fine for you? .
Regards,
veeraiyan chidambaram.
On Tue, Sep 10, 2019 at 04:45:29AM +0000, Yoshihiro Shimoda wrote:
> Hi Veeraiyan,
>
> Thank you for the patch!
>
> > From: Veeraiyan Chidambaram, Sent: Tuesday, September 10, 2019 12:46 AM
> <snip>
> > Commit [1] enabled the possibility of checking the DVST (Device State
> > Transition) bit of INTSTS0 (Interrupt Status Register 0) and calling
> > the irq_dev_state() handler if the DVST bit is set. But neither
> > commit [1] nor commit [2] actually enabled the DVSE (Device State
> > Transition Interrupt Enable) bit in the INTENB0 (Interrupt Enable
> > Register 0). As a consequence, irq_dev_state() handler is getting
> > called as a side effect of other (non-DVSE) interrupts being fired,
> > which definitely can't be relied upon, if DVST notifications are of
> > any value.
> >
> > Why this doesn't hurt is because usbhsg_irq_dev_state() currently
> > doesn't do much except of a dev_dbg(). Once more work is added to
> > the handler (e.g. detecting device "Suspended" state and notifying
> > other USB gadget components about it), enabling DVSE becomes a hard
> > requirement. Do it in a standalone commit for better visibility and
> > clear explanation.
> >
> > [1] f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code")
> > [2] 2f98382dcdfe ("usb: renesas_usbhs: Add Renesas USBHS Gadget")
>
> I'm afraid I should have realized but, according to checkpatch.pl,
> these formats cause ERROR like below. So, they should be fixed.
>
> ERROR: Please use git commit description style 'commit <12+ chars of sha1>
> ("<title line>")' - ie: 'commit f1407d5c6624 ("usb: renesas_usbhs: Add
> Renesas USBHS common code")'
> #90:
> [1] f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code")
>
> ERROR: Please use git commit description style 'commit <12+ chars of sha1>
> ("<title line>")' - ie: 'commit 2f98382dcdfe ("usb: renesas_usbhs: Add
> Renesas USBHS Gadget")'
> #91:
> [2] 2f98382dcdfe ("usb: renesas_usbhs: Add Renesas USBHS Gadget")
>
> Best regards,
> Yoshihiro Shimoda
>
