On Wed, Sep 11, 2019 at 11:33:03PM +0100, Kieran Bingham wrote:
> Hi Andy!
>
> On 05/09/2019 16:05, Andrew Murray wrote:
> > Remove unnecessary header include (../pci.h) since it doesn't
> > provide any needed symbols.
>
> This appears to have been added in 9e2aee80c78d ("PCI: Move private DT
> related functions into private header")
Thanks, I never looked back at the history of this.
>
> Several other drivers were touched in that commit too.
>
> Have you checked to see if any others can also be cleaned up?
Yes I went through all the current drivers/pci/host/ files, I believe this
was the only one.
>
> (I only ask, because I only see this single patch on linux-renesas-soc,
> my apologies if others are on different lists.)
>
> Regardless of that, this looks fine to me, and passes a cursory compile
> check.
>
> And I've just tried with pcie-xilinx, and pcie-altera, but both still
> need this header - so perhaps pcie-rcar was just the odd one out.
>
> Reviewed-by: Kieran Bingham <[email protected]>
Thanks,
Andrew Murray
>
>
> > Signed-off-by: Andrew Murray <[email protected]>
> > ---
> > drivers/pci/controller/pcie-rcar.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/pci/controller/pcie-rcar.c
> > b/drivers/pci/controller/pcie-rcar.c
> > index f6a669a9af41..ee1c38c2fac9 100644
> > --- a/drivers/pci/controller/pcie-rcar.c
> > +++ b/drivers/pci/controller/pcie-rcar.c
> > @@ -30,8 +30,6 @@
> > #include <linux/pm_runtime.h>
> > #include <linux/slab.h>
> >
> > -#include "../pci.h"
> > -
> > #define PCIECAR 0x000010
> > #define PCIECCTLR 0x000018
> > #define CONFIG_SEND_ENABLE BIT(31)
> >
>
