Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Wednesday, October 9, 2019 8:31 PM
>
> Hi Shimoda-san,
>
> On Wed, Oct 9, 2019 at 1:05 PM Yoshihiro Shimoda
> <[email protected]> wrote:
<snip>
> > @@ -615,6 +616,8 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie)
> > if (IS_ENABLED(CONFIG_PCI_MSI))
> > rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR);
> >
> > + rcar_rmw32(pcie, MACCTLR, MACCTLR_RESERVED, 0);
> > +
> > /* Finish initialization - establish a PCI Express link */
> > rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR);
>
> I guess the same should be added to rcar_pcie_resume_noirq(),
> as s2ram on R-Car Gen3 powers down the SoC?
Thank you for the pointed it out! You're correct. So, I'll update
the patch.
Best regards,
Yoshihiro Shimoda
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
