> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> b/drivers/net/ethernet/renesas/ravb_main.c
> index 4f648394e645..9618c4881c83 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1980,8 +1987,12 @@ static void ravb_set_delay_mode(struct net_device
> *ndev)
> set |= APSR_DM_RDM;
>
> if (priv->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
> - priv->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID)
> - set |= APSR_DM_TDM;
> + priv->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID) {
> + if (!WARN(soc_device_match(ravb_delay_mode_quirk_match),
> + "phy-mode %s requires TX clock internal delay mode
> which is not supported by this hardware revision. Please update device tree",
> + phy_modes(priv->phy_interface)))
> + set |= APSR_DM_TDM;
> + }
>
> ravb_modify(ndev, APSR, APSR_DM, set);
> }
Hi Simon
This looks good. Please add my:
Reviewed-by: Andrew Lunn <[email protected]>
To the real patch.
Andrew
