On Fri, 2006-12-15 at 23:37 +0100, Robert Schwebel wrote:
>  /*
>   * IRQ handler for the timer
>   */
>  static irqreturn_t
>  netx_timer_interrupt(int irq, void *dev_id)
>  {
> -     write_seqlock(&xtime_lock);
> -
> -     timer_tick();
> -
> -     write_sequnlock(&xtime_lock);
> -
>       /* acknowledge interrupt */
>       writel(COUNTER_BIT(0), NETX_GPIO_IRQ);
>  
> +     if (clockevent_netx.event_handler)
> +             clockevent_netx.event_handler();

Why is this conditional? The timer interrupt should only happen, when
the clock event devices has been registerd and the ->set_mode function
has been called.

> +static void netx_set_mode(enum clock_event_mode mode, struct 
> clock_event_device *evt)
> +{
> +     clockevent_mode = mode;
> +}

set_mode() is there on purpose. It is used by the generic framework to
control the timer (enable in periodic/oneshot mode) or shutdown the
timer. 

        tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to