Hello, On Tuesday, January 12, 2010 5:20 AM Ben Dooks wrote:
> From: Ben Dooks <ben-li...@fluff.org> > > Remove the definitions we've deleted in the previous updates to the > clksrc_clk for arch/arm/plat-s5pc1xx/include/plat/regs-clock.h. > > Signed-off-by: Ben Dooks <ben-li...@fluff.org> > --- > arch/arm/plat-s5pc1xx/include/plat/regs-clock.h | 60 > ----------------------- > 1 files changed, 0 insertions(+), 60 deletions(-) > > diff --git a/arch/arm/plat-s5pc1xx/include/plat/regs-clock.h b/arch/arm/plat- > s5pc1xx/include/plat/regs-clock.h > index c5cc86e..e88562e 100644 > --- a/arch/arm/plat-s5pc1xx/include/plat/regs-clock.h > +++ b/arch/arm/plat-s5pc1xx/include/plat/regs-clock.h > @@ -62,53 +62,16 @@ > #define S5PC100_EPLLVAL(_m, _p, _s) ((_m) << 16 | ((_p) << 8) | ((_s))) > > /* CLKSRC0 */ > -#define S5PC100_CLKSRC0_APLL_MASK (0x1<<0) > -#define S5PC100_CLKSRC0_APLL_SHIFT (0) > -#define S5PC100_CLKSRC0_MPLL_MASK (0x1<<4) > -#define S5PC100_CLKSRC0_MPLL_SHIFT (4) > -#define S5PC100_CLKSRC0_EPLL_MASK (0x1<<8) > -#define S5PC100_CLKSRC0_EPLL_SHIFT (8) > -#define S5PC100_CLKSRC0_HPLL_MASK (0x1<<12) > -#define S5PC100_CLKSRC0_HPLL_SHIFT (12) > -#define S5PC100_CLKSRC0_AMMUX_MASK (0x1<<16) > -#define S5PC100_CLKSRC0_AMMUX_SHIFT (16) > #define S5PC100_CLKSRC0_HREF_MASK (0x1<<20) > #define S5PC100_CLKSRC0_HREF_SHIFT (20) > -#define S5PC100_CLKSRC0_ONENAND_MASK (0x1<<24) > -#define S5PC100_CLKSRC0_ONENAND_SHIFT (24) > ... > /* CLKDIV2 */ > #define S5PC100_CLKDIV2_UART_MASK (0x7<<0) > -#define S5PC100_CLKDIV2_UART_SHIFT (0) > #define S5PC100_CLKDIV2_SPI0_MASK (0xf<<4) > -#define S5PC100_CLKDIV2_SPI0_SHIFT (4) > #define S5PC100_CLKDIV2_SPI1_MASK (0xf<<8) > -#define S5PC100_CLKDIV2_SPI1_SHIFT (8) > #define S5PC100_CLKDIV2_SPI2_MASK (0xf<<12) > -#define S5PC100_CLKDIV2_SPI2_SHIFT (12) > #define S5PC100_CLKDIV2_IRDA_MASK (0xf<<16) > #define S5PC100_CLKDIV2_IRDA_SHIFT (16) > #define S5PC100_CLKDIV2_UHOST_MASK (0xf<<20) > -#define S5PC100_CLKDIV2_UHOST_SHIFT (20) > ... IMHO it is not a good idea to remove these defines selectively. Header would look strange and one might conclude that something is missing. Removing all of them is also a bad idea, because some important information is lost in such case (it would be harder to add missing clocks to the system). Half of these defines are redundant anyway, so maybe we should leave only *_MASK defines for informational purpose? Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
