Tejun Heo wrote: > > Hello, > > On 05/27/2010 10:22 AM, Kukjin Kim wrote: > > From: Abhilash Kesavan <[email protected]> > > > > Adds support for the Samsung PATA controller. This driver is based on the > > Libata subsystem and references the earlier patches sent for IDE subsystem. > > Just one small thing. > > > +static struct ata_port_operations pata_s3c_port_ops = { > > + .inherits = &ata_sff_port_ops, > > + .sff_check_status = pata_s3c_check_status, > > + .sff_tf_load = pata_s3c_tf_load, > > + .sff_tf_read = pata_s3c_tf_read, > > + .sff_data_xfer = pata_s3c_data_xfer, > > + .sff_exec_command = pata_s3c_exec_command, > > + .qc_prep = ata_noop_qc_prep, > > + .set_piomode = pata_s3c_set_piomode, > > +}; > > + > > +static struct ata_port_operations pata_s5p_port_ops = { > > + .inherits = &ata_sff_port_ops, > > + .qc_prep = ata_noop_qc_prep, > > + .set_piomode = pata_s3c_set_piomode, > > +}; > > You don't need to override .qc_prep to ata_noop_qc_prep() and can you > please base the patch against the current libata-dev#upstream? > Will remove the override and rebase the new patches against upstream branch.
Thanks. Best regards, Kgene. -- Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
