В сообщении от 8 сентября 2010 02:06:19 автор Ben Dooks написал: > On 07/09/10 15:32, Vasily Khoruzhick wrote: > > Signed-off-by: Vasily Khoruzhick <[email protected]> > > --- > > > > arch/arm/mach-s3c2440/Kconfig | 3 + > > arch/arm/mach-s3c2440/mach-rx1950.c | 160 > > +++++++++++++++++++++++++++++++++++ 2 files changed, 163 insertions(+), > > 0 deletions(-) > > > > diff --git a/arch/arm/mach-s3c2440/Kconfig > > b/arch/arm/mach-s3c2440/Kconfig index cd8e7de..9b6b026 100644 > > --- a/arch/arm/mach-s3c2440/Kconfig > > +++ b/arch/arm/mach-s3c2440/Kconfig > > @@ -198,6 +198,9 @@ config MACH_RX1950 > > > > select S3C_DEV_NAND > > select S3C2410_IOTIMING if S3C2440_CPUFREQ > > select S3C2440_XTAL_16934400 > > > > + select S3C_ADC > > + select PDA_POWER > > + select BATTERY_S3C_ADC > > not keen on forcing these on unless they are required for the > system to work.
Ok
> > + {3629, 178, 10},
> > + {3612, 162, 5},
> > + {3605, 162, 0},
> > +
>
> at least add a space after { and before }
> it would be nice to have named initialisers.
Ok, I'll add named initialisers
Regards
Vasily
signature.asc
Description: This is a digitally signed message part.
