On Mon, Sep 13, 2010 at 10:45 AM, Chanwoo Choi <[email protected]> wrote: > This patch the I2C board information for the WM8994 used in the Goni/Aquila > as audio codec and adds the I2C/I2S platform drivers. Additionlly, to > control power consumption have registerd the voltage consumer of WM8994 > to the regulator framework. > > Additionally, I explain the constraints of the regulator of WM8994 codec. > All these consumer supply of WM8994 codec connected the regulator(VCC_1.8V) > on a circuit diagram. "VCC_1.8V" regulator is always enabled, because it is > used to many devices on Goni/Aquila board. This is required especially > when there are many devices physically attached to "VCC_1.8V" and some of > they did not "register" as consumers to "VCC_1.8V". "VCC_1.8V" might be > turned off by those who are registered while "unregistered" are still active. > > Signed-off-by : Chanwoo Choi <[email protected]> > Signed-off-by : Joonyoung Shim <[email protected]> > Signed-off-by : Kyungmin Park <[email protected]> > --- > arch/arm/mach-s5pv210/mach-aquila.c | 170 > +++++++++++++++++++++++++++++++++++ > arch/arm/mach-s5pv210/mach-goni.c | 157 ++++++++++++++++++++++++++++++++
The contents seem ok (at least the audio related). But it would have been better if you had broken the patch into three a) Regulator support adding (90% of the code and should have been CC'd to Mark and Liam as well) b) I2C related. c) Audio related Preferably further divided for each machine. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
