Hi,
> I commented as belows,
> And you missed one important things 'cause there were my comments
> in the very long email which is strongly fixed in the reset seq.
Yes, thanks for your suggestion.
>
> [....]
> > +#define READL(offset) readl(dev->regs_base + (offset))
> > +#define WRITEL(data, offset) writel((data), dev->regs_base +
> (offset))
> > +#define OFFSETA(x) (((x) - dev->port_a) >> 11)
> > +#define OFFSETB(x) (((x) - dev->port_b) >> 11)
> > +
> > +/* Reset the device */
> > +static int s5p_mfc_cmd_reset(struct s5p_mfc_dev *dev)
> > +{
> > + unsigned int mc_status;
> > + unsigned long timeout;
> > + mfc_debug("s5p_mfc_cmd_reset++\n");
> > + /* Stop procedure */
> > + WRITEL(0x3f7, S5P_FIMV_SW_RESET); /* reset VI */
>
> Ahm, This (WRITEL(0x3f7, S5P_FIMV_SW_RESET)) might be a problem.
> In the reset seq. of MFC driver, we checked out
> That FW(s5pc110-mfc.fw in the s5p_mfc_load_firmware()) runned by RISC
> core
> at this point could access invalid address. It should be removed.
>
Thanks for pointing this out. I will remove it in the next version.
[snip]
Best regards
--
Kamil Debski
Linux Platform Group
Samsung Poland R&D Center
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
