On Fri, Nov 12, 2010 at 07:40:16PM +0900, Inki Dae wrote:
>
> > -----Original Message-----
> > From: Paul Mundt [mailto:let...@linux-sh.org]
> > Sent: Friday, November 12, 2010 7:09 PM
> > To: Inki Dae
> > Cc: 'Kukjin Kim'; 'Sangbeom Kim'; linux-arm-ker...@lists.infradead.org;
> > linux-samsung-soc@vger.kernel.org; linux-fb...@vger.kernel.org; ben-
> > li...@fluff.org; a...@linux-foundation.org; 'Jonghun Han'
> > Subject: Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD
> >
> > On Fri, Nov 12, 2010 at 06:54:29PM +0900, Inki Dae wrote:
> > > @@ -1314,13 +1319,22 @@ static int __devinit s3c_fb_probe(struct
> > > platform_device *pdev)
> > > sfb->pdata = pd;
> > > sfb->variant = fbdrv->variant;
> > >
> > > - sfb->bus_clk = clk_get(dev, "lcd");
> > > - if (IS_ERR(sfb->bus_clk)) {
> > > - dev_err(dev, "failed to get bus clock\n");
> > > + /* if sclk_name is NULL then it would use bus clock as default. */
> > > + if (!pd->sclk_name)
> > > + sfb->lcd_clk = clk_get(dev, "lcd");
> > > + else
> > > + sfb->lcd_clk = clk_get(dev, pd->sclk_name);
> > > +
> > No, this is totally pointless. Simply establish a clk lookup for the
> > configuration you are running on in your board code
> You mean, call the function at s3c_fb_probe() establishing clk lookup in
> board code?
> Sorry but I could understand. Please give me more detail.
>
I mean use a clkdev lookup for resolving the clock instead of passing
around a string via platform data. Look at the asm/clkdev.h API and all
of the boards that are using it.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
