Sangbeom Kim wrote: > > This patch add pcm audio configuration for SMDKV210 and SMDKC110. > Platform device and pcm clock initialization code is added. > > Signed-off-by: Sangbeom Kim <[email protected]> > ---
(snip) > @@ -0,0 +1,45 @@ > +/* arch/arm/mach-s5pv210/include/mach/regs-clock.h arch/arm/mach-s5pv210/include/mach/regs-audss.h ? (snip) > +/* CLKSRC0 */ > +#define S5P_AUDSS_CLKSRC_MAIN_MASK (0x1<<0) > +#define S5P_AUDSS_CLKSRC_MAIN_SHIFT (0) Firstly, the blank should be added around "<<" like following. +#define S5P_AUDSS_CLKSRC_MAIN_MASK (0x1 << 0) Secondly, if you want to use XXX_SHIFT, please use like following. +#define S5P_AUDSS_CLKSRC_MAIN_SHIFT (0) +#define S5P_AUDSS_CLKSRC_MAIN_MASK (0x1 << S5P_AUDSS_CLKSRC_MAIN_SHIFT) Finally, if the definition is not used anywhere, please don't add it. Thanks. Best regards, Kgene. -- Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
