Hi, Mythri.
> -----Original Message-----
> From: [email protected] [mailto:linux-fbdev-
> [email protected]] On Behalf Of K, Mythri P
> Sent: Thursday, June 23, 2011 6:04 PM
> To: [email protected]
> Cc: Kukjin Kim; Paul Mundt; [email protected]; linux-
> [email protected]; Jong-Hun Han; ANAND KUMAR N; Sylwester Nawrocki;
> THOMAS P ABRAHAM; Marek Szyprowski; Kyungmin Park; In-Ki Dae; ARM Linux;
> Ben Dooks
> Subject: Re: [PATCH V4 5/5] ARM: EXYNOS4: Add platform data for EXYNOS4
> FIMD and LTE480WV platform-lcd
>
> 2011/6/22 JinGoo Han <[email protected]>:
> > From: Jonghun Han <[email protected]>
> >
> > This patch adds support EXYNOS4 FIMD0 and LTE480WV LCD pannel.
> >
> > Signed-off-by: Jonghun Han <[email protected]>
> > Signed-off-by: Jingoo Han <[email protected]>
> > ---
> > arch/arm/mach-exynos4/mach-smdkc210.c | 114
> +++++++++++++++++++++++++++++++++
> > arch/arm/mach-exynos4/mach-smdkv310.c | 114
> +++++++++++++++++++++++++++++++++
> > 2 files changed, 228 insertions(+), 0 deletions(-)
> >
> <<snip>>
> > +static void lcd_lte480wv_set_power(struct plat_lcd_data *pd,
> > + unsigned int power)
> > +{
> > + if (power) {
> > +#if !defined(CONFIG_BACKLIGHT_PWM)
> > + gpio_request(EXYNOS4_GPD0(1), "GPD0");
> > + gpio_direction_output(EXYNOS4_GPD0(1), 1);
> > + gpio_free(EXYNOS4_GPD0(1));
> > +#endif
> > + /* fire nRESET on power up */
> > + gpio_request(EXYNOS4_GPX0(6), "GPX0");
> > +
> > + gpio_direction_output(EXYNOS4_GPX0(6), 1);
> > + mdelay(100);
> > +
> > + gpio_set_value(EXYNOS4_GPX0(6), 0);
> > + mdelay(10);
> > +
> > + gpio_set_value(EXYNOS4_GPX0(6), 1);
> > + mdelay(10);
> > +
> > + gpio_free(EXYNOS4_GPX0(6));
> > + } else {
> > +#if !defined(CONFIG_BACKLIGHT_PWM)
> > + gpio_request(EXYNOS4_GPD0(1), "GPD0");
> > + gpio_direction_output(EXYNOS4_GPD0(1), 0);
> > + gpio_free(EXYNOS4_GPD0(1));
> > +#endif
> > + }
> > +}
> > +
>
> have you considered using gpio_request_one instead ? It simplifies the
> three step API.
You're right. It seems to be very helpful.
I will apply it and send V7 patches, soon.
Thank you for your reply.
>
> <<snip>>
>
> > + if (power) {
> > +#if !defined(CONFIG_BACKLIGHT_PWM)
> > + gpio_request(EXYNOS4_GPD0(1), "GPD0");
> > + gpio_direction_output(EXYNOS4_GPD0(1), 1);
> > + gpio_free(EXYNOS4_GPD0(1));
> > +#endif
> > + /* fire nRESET on power up */
> > + gpio_request(EXYNOS4_GPX0(6), "GPX0");
> > +
> > + gpio_direction_output(EXYNOS4_GPX0(6), 1);
> > + mdelay(100);
> > +
> > + gpio_set_value(EXYNOS4_GPX0(6), 0);
> > + mdelay(10);
> > +
> > + gpio_set_value(EXYNOS4_GPX0(6), 1);
> > + mdelay(10);
> > +
> > + gpio_free(EXYNOS4_GPX0(6));
> > + } else {
> > +#if !defined(CONFIG_BACKLIGHT_PWM)
> > + gpio_request(EXYNOS4_GPD0(1), "GPD0");
> > + gpio_direction_output(EXYNOS4_GPD0(1), 0);
> > + gpio_free(EXYNOS4_GPD0(1));
> > +#endif
> > + }
> > +}
>
> same comment as above.
>
> <<snip>>
>
>
>
> --
> Thanks and regards,
> Mythri.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{굇ß틏,″㎍썳變}찠꼿쟺�&j:+v돣�쳭喩zZ+�+zf＂톒쉱�~넮녬i鎬z� 췿ⅱ�?솳鈺�&�)刪f
