On Fri, Sep 2, 2011 at 6:14 AM, Boojin Kim <[email protected]> wrote: > Origianl code carries out the start operation after flush operation. > But start operation is not required for DMA_TERMINATE_ALL command. > So, This patch removes the unnecessary start operation and only carries out > the flush oeration for handling DMA_TERMINATE_ALL command.
Not exactly. The 'start' is impotent when called from this path because there is nothing left queued after the call to 'flush'. pl330_tasklet() is called because that is a common function that does the house-keeping acc to what's presently in 'work' and 'done' lists. Though as a side-effect, your patch does avoid doing callbacks on submitted xfers during DMA_TERMINATE_ALL - which may or may not be the right thing to do. I remember seeing some dmac drivers doing the callbacks while some specifically avoiding them during DMA_TERMINATE_ALL. While I personally prefer the former, I guess it's for maintainers to decide. Vinod ? -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
