Marek Szyprowski wrote: > > Loop iterator value after terminating list_for_each_entry() is not NULL. > This patch fixes incorrect iterator usage in GPIO interrupt code for > Samsung S5P platforms. > > Signed-off-by: Marek Szyprowski <[email protected]> > Signed-off-by: Kyungmin Park <[email protected]> > --- > arch/arm/plat-s5p/irq-gpioint.c | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/plat-s5p/irq-gpioint.c b/arch/arm/plat-s5p/irq-gpioint.c > index 0455519..a566523 100644 > --- a/arch/arm/plat-s5p/irq-gpioint.c > +++ b/arch/arm/plat-s5p/irq-gpioint.c > @@ -114,17 +114,18 @@ static __init int s5p_gpioint_add(struct > samsung_gpio_chip *chip) > { > static int used_gpioint_groups = 0; > int group = chip->group; > - struct s5p_gpioint_bank *bank = NULL; > + struct s5p_gpioint_bank *b, *bank = NULL; > struct irq_chip_generic *gc; > struct irq_chip_type *ct; > > if (used_gpioint_groups >= S5P_GPIOINT_GROUP_COUNT) > return -ENOMEM; > > - list_for_each_entry(bank, &banks, list) { > - if (group >= bank->start && > - group < bank->start + bank->nr_groups) > + list_for_each_entry(b, &banks, list) { > + if (group >= b->start && group < b->start + b->nr_groups) { > + bank = b; > break; > + } > } > if (!bank) > return -EINVAL; > -- > 1.7.1.569.g6f426
OK, applied. Thanks. Best regards, Kgene. -- Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
