Maya Erez wrote: > >> >>> >> >> > + if (rqc) > >> >>> >> >> > + reqs = mmc_blk_chk_packable(mq, rqc); > >> >>> > >> >>> It would be best to keep all the calls to blk_fetch_request in the > >> same > >> >>> location. Therefore, I suggest to move the call to > >> mmc_blk_chk_packable > >> >>> to > >> >>> mmc/card/queue.c after the first request is fetched. > >> >> > >> >> At the first time, I considered that way. > >> >> I'll do more, if possible. > > I considered more. > > I think that mmc_blk_chk_packable would rather be called only for r/w type > > than all request type(e.g. discard, flush). > > > mmc_blk_chk_packable can check the cmd_flags of the request to verify it's > not a flush/disacrad etc. In such cases will not pack. Yes. It must be checked, but omitted. I already have added this check. It will be applied next.
Thanks, Seungwon Jeon. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
