On 12/26/2011 08:06 PM, Mark Brown wrote:
> On Mon, Dec 12, 2011 at 09:16:29PM +0530, Thomas Abraham wrote:
>
>> + /* Wait max 1ms */
>> + timeout = 10;
>> + while ((__raw_readl(base + 0x4) & S5P_INT_LOCAL_PWR_EN)
>> + != S5P_INT_LOCAL_PWR_EN) {
>> + if (!timeout) {
>> + pr_err("Power domain %s enable failed\n", domain->name);
>> + return -ETIMEDOUT;
>> + }
>> + timeout--;
>> + udelay(100);
>> + }
>
> Might be worth putting a cpu_relax() in there just to be a bit nicer?
There is a quite significant delay within the loop, thus it might make more
sense to replace udelay() with usleep_range() instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
