On Wed, 2012-01-04 at 05:23 -0500, R, Durgadoss wrote: > Hi Amit Daniel, > > > Hi Guenter, > > > > The main idea of this work is to leave the current userspace based > > notification scheme and add the kernel based cooling scheme on top of > > it. Anyway, It is a good idea to move the file hwmon/exynos4_tmu.c as > > But, What I feel is, kernel based cooling scheme will work only for > Controlling 'CPU' frequency. But in SoC's there are other devices that > Contribute to Thermal. For example, GPU, Display, Battery (during charging) > etc.. In this case, we need a user space to control these devices. So, in a > way, the user space notification mechanism is a unified solution for > throttling all devices and keeps the kernel code light weight. > > I am also curious to know why the existing mechanism did not work for you ? > That is one question.
For me, the main concern is that the proposed implementation creates duplicate hwmon entries for the same device, which is simply messy. If both the kernel thermal mechanism and the userspace mechanism are needed, I think it would make more sense to use a thermal driver and have that thermal driver generate the necessary userspace events. Thanks, Guenter > Thanks, > Durga > > > this creates 2 hwmon entries. > > Adding CC: Donggeun Kim to know his opinion. > > > > Thanks, > > Amit Daniel > [snip.] -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
