On 10 August 2012 11:44, Kukjin Kim <[email protected]> wrote: > Sachin Kamat wrote: >> >> Since support for Exynos5 SoC based boards is going to be only >> device tree (DT) based, it makes no sense to provide DT as a user >> selectable feature in menuconfig (De-selecting it gives >> "no machine record defined" linker error). Hence enabling it along with >> ARCH_EXYNOS5 option. >> > Yeah, it's true supporting EXYNOS5 SoCs is available only on DT. But I think > this is not needed and current method is more clear with EXYNOS4.
Exynos4 supports both DT as well as non-DT platforms. Hence it is appropriate to have DT as a user selectable option in Exynos4 case. > > Note, 'exynos_defconfig' in mainline is supporting EXYNOS4 and EXYNOS5 DT > together. Even this config provides a user selectable DT option for Exynos5. When there is no possibility of having a non-DT platform for Exynos5 (atleast as of now), I do not see the need to provide a user selectable option (it also leads to build errors with played around with as mentioned in my patch) for DT for Exynos5 as it _has_ to be enabled if one needs to build the kernel for Exynos5 machines. > > >> Signed-off-by: Sachin Kamat <[email protected]> >> Signed-off-by: Sachin Kamat <[email protected]> > > BTW, I commented on other patch, I don't see why you need to keep the > duplicated signoff? Please refer to my reply to previous patch. > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <[email protected]>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
