Am Montag, 19. November 2012, 15:33:57 schrieb Alexander Varnin: > Actually, SPI channel 0 on 2443 is mapped to HS SPI controller, > and to enable s3c2410-spi controller, we should power on channel > 1 in PCLKCON. There is no channel 0 SPI on s3c2443, so delete its > clock. > > Signed-off-by: Alexander Varnin <[email protected]>
You're right of course. The second spi channel (pclkcon_spi1) even uses the registers for the first s3c24xx-spi channel. Reviewed-by: Heiko Stuebner <[email protected]> But you might want to resend your patch and include Kukjin Kim <[email protected]> (the maintainer of Samsung code) as recipient, because I don't know if he'll see it otherwise. > --- > arch/arm/mach-s3c24xx/clock-s3c2443.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/mach-s3c24xx/clock-s3c2443.c > b/arch/arm/mach-s3c24xx/clock-s3c2443.c index 7f689ce..bdaba59 100644 > --- a/arch/arm/mach-s3c24xx/clock-s3c2443.c > +++ b/arch/arm/mach-s3c24xx/clock-s3c2443.c > @@ -158,12 +158,6 @@ static struct clk init_clocks_off[] = { > .devname = "s3c2410-spi.0", > .parent = &clk_p, > .enable = s3c2443_clkcon_enable_p, > - .ctrlbit = S3C2443_PCLKCON_SPI0, > - }, { > - .name = "spi", > - .devname = "s3c2410-spi.1", > - .parent = &clk_p, > - .enable = s3c2443_clkcon_enable_p, > .ctrlbit = S3C2443_PCLKCON_SPI1, > } > }; -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
