Hi Sylwester, Thank you for the review.
>> +Sensor sub-nodes: >> + >> +FIMC-IS IP supports custom built sensors to be controlled exclusively by >> +the FIMC-IS firmware. These sensor properties are to be defined here. > [snip] > > Defining image sensor nodes in a standard way as ISP I2C bus controller > nodes has an disadvantage that we need dummy I2C bus controller driver, > at least this is how I have written the driver for Exynos4x12. In some > version of it I had sensor nodes put in a isp-i2c fimc-is sub-node, but > then there was an issue that this was not a fully specified I2C bus > controller node. > > You can refer to my exynos4 fimc-is patch series for details on how this > is now implemented. > > Handling the image sensor in a standard way, as regular I2C client devices > has an advantage that we can put pinctrl properties in relevant device > nodes, > where available, which more closely describes the hardware structure. > > I'm not really sure in 100% if all this complication is required. It would > allow to use same DT blob for different Imaging Subsystem SW architecture. > For example some parts of functionality handled currently by FIMC-IS (ARM > Cortex-A5) could be moved to host CPU, without any change in the device > tree structure. The kernel could decide e.g. if it uses image sensor driver > implemented in the ISP firmware, or a driver run on the host CPU. > > What do you think ? > I have seen your Exynos4 FIMC-IS patchset and you have made a dummy I2C sensor driver there. That mode would work fine in Exynos4 since the sensor and ISP will be used by the same media controller pipeline. So the ISP component in the pipeline will ensure that the HW is initialized and sensor is working. But in Exynos5, we are using sensor in pipeline0 and ISP in pipeline1. So there is a possibility of using sensor subdev independently without using pipeline1 ISP components. So with the driver I sent, the pipeline0 can still work like this --> ISP sensor ---> MIPI-CSIS ---> FIMC-LITE ---> Memory This cannot be done if a dummy I2C driver is made for ISP sensor. What is your suggestion on this? Regards Arun -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
