On Tuesday 18 June 2013, Tomasz Figa wrote:
> OK. Looking forward to it.
>
> Btw. This leaves us with two things broken:
> - sdhci-s3c checks for defined(CONFIG_SOC_EXYNOS4212), but does not check
> for defined(CONFIG_SOC_EXYNOS4412),
> - exynos-thermal checks for defined(CONFIG_SOC_EXYNOS4412), but does not
> check for defined(CONFIG_SOC_EXYNOS4212).
>
> I think this must be fixed, because selecting only Exynos4212 in kernel
> config you end up without exynos-thermal, while selecting only Exynos4412
> breaks sdhci-s3c.
I wonder what we actually gain by having all these fine-grained checks
in the kernel. Why not just reduce the compile-time checks to just
EXYNOS4 and EXYNOS5?
The drivers can easily implement code for all variants using
run-time checks, but I think it would be easier if building an EXYNOS4
kernel would just run on all EXYNOS4 machines.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
