On 07/20/2013 02:04 AM, Tomasz Figa wrote: > PWM channel 4 has its autoreload bit located at different position. This > patch fixes the driver to account for that. > > This fixes a problem with the clocksource hanging after it overflows because > it is not reloaded any more. > > Signed-off-by: Tomasz Figa <[email protected]> > --- > drivers/clocksource/samsung_pwm_timer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clocksource/samsung_pwm_timer.c > b/drivers/clocksource/samsung_pwm_timer.c > index 3fa5b07..e238fb0 100644 > --- a/drivers/clocksource/samsung_pwm_timer.c > +++ b/drivers/clocksource/samsung_pwm_timer.c > @@ -47,7 +47,8 @@ > #define TCON_START(chan) (1 << (4 * (chan) + 0)) > #define TCON_MANUALUPDATE(chan) (1 << (4 * (chan) + 1)) > #define TCON_INVERT(chan) (1 << (4 * (chan) + 2)) > -#define TCON_AUTORELOAD(chan) (1 << (4 * (chan) + 3)) > +#define TCON_AUTORELOAD(chan) (1 << (4 * (chan) \ > + + (((chan) < 5) ? 3 : 2)))
This macro is not readable. Please, fix it up with a comment please. > > DEFINE_SPINLOCK(samsung_pwm_lock); > EXPORT_SYMBOL(samsung_pwm_lock); > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
