On Tuesday, October 01, 2013 10:49 PM, Sylwester Nawrocki wrote: > On 10/01/2013 03:33 AM, Jingoo Han wrote: > > On Sunday, September 29, 2013 11:29 AM, Wei Yongjun wrote: > >> > >> From: Wei Yongjun<[email protected]> > >> > >> Add the missing clk_disable_unprepare() before return > >> from exynos_pcie_probe() in the error handling case. > >> > >> Signed-off-by: Wei Yongjun<[email protected]> > > > > Acked-by: Jingoo Han<[email protected]> > > > > However, the commit name should be fixed as below: > > [PATCH] PCI: exynos: use missing clk_disable_unprepare() on error in > > exynos_pcie_probe() > > Perhaps just: > > "PCI: exynos: Add missing clk_disable_unprepare() on error path > > How can something that is missing be used ? :)
Hi Sylwester Nawrocki, OK, I see. The following looks good, as you mentioned. [PATCH] PCI: exynos: Add missing clk_disable_unprepare() on error path Thank you for your comment. :-) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
