Hi Sachin,

Please see my comments inline.

On Tuesday 05 of November 2013 17:09:20 Sachin Kamat wrote:
> Added high speed I2C nodes to Exynos5420 DT file.
> 
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |   98 
> +++++++++++++++++++++++++++++++++++++
>  1 file changed, 98 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi 
> b/arch/arm/boot/dts/exynos5420.dtsi
> index 9ce5f82..469769a 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -34,6 +34,13 @@
>               i2c1 = &i2c_1;
>               i2c2 = &i2c_2;
>               i2c3 = &i2c_3;
> +             i2c4 = &hsi2c_4;
> +             i2c5 = &hsi2c_5;
> +             i2c6 = &hsi2c_6;
> +             i2c7 = &hsi2c_7;
> +             i2c8 = &hsi2c_8;
> +             i2c9 = &hsi2c_9;
> +             i2c10 = &hsi2c_10;
>               gsc0 = &gsc_0;
>               gsc1 = &gsc_1;
>       };
> @@ -339,6 +346,97 @@
>               status = "disabled";
>       };
>  
> +     hsi2c_4: hsi2c@12CA0000 {

nit: Node name should be generic, so simply i2c@unit-address should be
enough.

The same for remaining instances.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to