Hi Chanho,

On 14.04.2014 14:48, Chanho Park wrote:
This patch adds a hsotg node for exynos4 USB2.0 device controller.

Cc: Tomasz Figa <t.f...@samsung.com>
Cc: Kamil Debski <k.deb...@samsung.com>
Cc: Marek Szyprowski <m.szyprow...@samsung.com>
Signed-off-by: Chanho Park <chanho61.p...@samsung.com>
---
  arch/arm/boot/dts/exynos4.dtsi | 11 +++++++++++
  1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 0e32d7f..e541ecb 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -288,6 +288,17 @@
                #phy-cells = <1>;
        };

+       hsotg@12480000 {
+               compatible = "samsung,s3c6400-hsotg";
+               reg = <0x12480000 0x20000>;
+               interrupts = <0 71 0>;
+               clocks = <&clock 305>;

Please use clock macros.

+               clock-names = "otg";
+               phys = <&exynos_usbphy 0>;
+               phy-names = "device";

This is not the correct phy name for this binding. According to what the driver uses and the example in ...bindings/usb/dwc2.txt "usb2-phy" should be used.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to