On 15 May 2014 01:21, Tomasz Figa <[email protected]> wrote: > Hi Rahul, > > On 14.05.2014 04:46, Rahul Sharma wrote: >> From: Rahul Sharma <[email protected]> >> >> "gpx3-7" is chip specific pin in Exynos5420 for hdmi >> hotplug. This pin is moved to exynos5420-pinctrl.dts >> and removed from the board file. >> >> Signed-off-by: Rahul Sharma <[email protected]> >> --- >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 --------- >> 1 file changed, 9 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> index 6910485..11cd9bf 100644 >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> @@ -131,15 +131,6 @@ >> }; >> }; >> >> - pinctrl@13400000 { >> - hdmi_hpd_irq: hdmi-hpd-irq { >> - samsung,pins = "gpx3-7"; >> - samsung,pin-function = <0>; >> - samsung,pin-pud = <1>; >> - samsung,pin-drv = <0>; > > Again, the same comment as for patch 1/5. This pin is being configured > as input, which doesn't look like a dedicated special function pin. > Shouldn't this node rather stay here? > Yea, I will take care fo this in v5.
> Best regards, > Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
