Hi Doug,
On 17 June 2014 21:27, Doug Anderson <diand...@chromium.org> wrote:
> Simon,
>
> On Tue, Jun 17, 2014 at 8:42 PM, Simon Glass <s...@chromium.org> wrote:
>>> diff --git a/drivers/input/keyboard/cros_ec_keyb.c
>>> b/drivers/input/keyboard/cros_ec_keyb.c
>>> index 4083796..dc37b6b 100644
>>> --- a/drivers/input/keyboard/cros_ec_keyb.c
>>> +++ b/drivers/input/keyboard/cros_ec_keyb.c
>>> @@ -191,8 +191,18 @@ static void cros_ec_keyb_close(struct input_dev *dev)
>>>
>>> static int cros_ec_keyb_get_state(struct cros_ec_keyb *ckdev, uint8_t
>>> *kb_state)
>>> {
>>> - return ckdev->ec->command_recv(ckdev->ec, EC_CMD_MKBP_STATE,
>>> - kb_state, ckdev->cols);
>>> + int ret;
>>> + struct cros_ec_command msg = {
>>> + .version = 0,
>>> + .command = EC_CMD_MKBP_STATE,
>>> + .outdata = NULL,
>>> + .outsize = 0,
>>> + .indata = kb_state,
>>> + .insize = ckdev->cols,
>>> + };
>>> +
>>> + ret = ckdev->ec->cmd_xfer(ckdev->ec, &msg);
>>
>> Do we need ret?
>
> No. If you wish I will spin without it. Let me know.
>
> Note that locally this code includes a comment between the above and the
> return:
> /* FIXME: This assumes msg.result == EC_RES_SUCCESS */
It's not important to me, and you've explained the other question.
Reviewed-by: Simon Glass <s...@chromium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
