On Tue, Jul 08, 2014 at 04:21:09PM +0200, Tomasz Figa wrote: > Hi Heiko, > > On 06.07.2014 20:42, Heiko Stübner wrote: > > On a lot of Samsung systems the watchdog is responsible for restarting the > > system and until now this code was contained in > > plat-samsung/watchdog-reset.c . > > > > With the introduction of the restart notifiers, this code can now move into > > driver itself, removing the need for arch-specific code. > > > > Tested on a S3C2442 based GTA02 > > Signed-off-by: Heiko Stuebner <[email protected]> > > --- > > drivers/watchdog/s3c2410_wdt.c | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > > index 7c6ccd0..3f89912 100644 > > --- a/drivers/watchdog/s3c2410_wdt.c > > +++ b/drivers/watchdog/s3c2410_wdt.c > > @@ -41,6 +41,7 @@ > > #include <linux/of.h> > > #include <linux/mfd/syscon.h> > > #include <linux/regmap.h> > > +#include <linux/reboot.h> > > > > #define S3C2410_WTCON 0x00 > > #define S3C2410_WTDAT 0x04 > > @@ -438,6 +439,31 @@ static inline void > > s3c2410wdt_cpufreq_deregister(struct s3c2410_wdt *wdt) > > } > > #endif > > > > +static struct s3c2410_wdt *s3c2410wdt_restart_ctx; > > This isn't the most elegant way to store context data. Maybe you could > embed the notifier_block struct into s3c2410_wdt struct and then use > container of to retrieve it from s3c2410wdt_restart_notify()? > Excellent idea. I'll do that for the moxart handler as well.
Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
