On 5 November 2014 08:47, Geert Uytterhoeven <[email protected]> wrote: > On Tue, Oct 28, 2014 at 3:38 PM, Ulf Hansson <[email protected]> wrote: >> --- a/drivers/base/power/domain.c >> +++ b/drivers/base/power/domain.c >> @@ -1358,25 +1358,81 @@ EXPORT_SYMBOL_GPL(pm_genpd_syscore_poweron); >> >> #endif /* CONFIG_PM_SLEEP */ >> >> -static struct generic_pm_domain_data *__pm_genpd_alloc_dev_data(struct >> device *dev) >> +static int genpd_alloc_dev_data(struct generic_pm_domain *genpd, >> + struct device *dev, struct gpd_timing_data >> *td) >> { > > [...] > >> + if (genpd->attach_dev) >> + genpd->attach_dev(dev); > > Note that dev->pm_domain is not yet set at this point, so the callee > can no longer > know to which domain the device is being attached. > Should we re-add the parameter, or move the attach_dev() back to > __pm_genpd_add_device(), like Kevin suggested.
I agree. I am working on a new version, which adopts to your suggestions. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
