Hi Vivek, Please see my comments below.
2014-11-24 22:02 GMT+09:00 Vivek Gautam <gautam.vi...@samsung.com>: > USB and Power regulator on Exynos7 require gpios available > in BUS1 pin controller block. > So adding the BUS1 pinctrl support. > > Signed-off-by: Naveen Krishna Ch <naveenkrishna...@gmail.com> > Signed-off-by: Vivek Gautam <gautam.vi...@samsung.com> > Cc: Linus Walleij <linus.wall...@linaro.org> > --- > > This patch was part of series: > "[PATCH 00/11] Exynos7: Adding USB 3.0 support" > https://lkml.org/lkml/2014/11/21/247 > > Changes since V1: > - Added support for all pin banks which are part of BUS1 pin controller. > > drivers/pinctrl/samsung/pinctrl-exynos.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) I have missed this with previous patch, but DT bindings documentation should list all aliases for all supported compatible strings, because they are required for correct operation. There is a small section about aliases in [1] already, so please add there information about aliases for Exynos7 pin controllers along with their names, e.g. Aliases for controllers compatible with "samsung,exynos7-pinctrl": - pinctrl0: pin controller of ALIVE block, - pinctrl1: pin controller of BUS0 block, [...] - pinctrl8: pin controller of BUS1 block. [1] Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt I guess you can do this in separate patch or respin this one with this added. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
