Hi Pankaj, On 27/09/14 07:41, Pankaj Dubey wrote: > Let's remove unnecessary include of header files from clk.h and add > required one in clk.c > > Signed-off-by: Pankaj Dubey <pankaj.du...@samsung.com> > --- > drivers/clk/samsung/clk.c | 3 ++- > drivers/clk/samsung/clk.h | 4 ---- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c > index 31bf391..952f9ec 100644 > --- a/drivers/clk/samsung/clk.c > +++ b/drivers/clk/samsung/clk.c > @@ -11,7 +11,8 @@ > * clock framework for Samsung platforms. > */ > > -#include <linux/syscore_ops.h>
I've dropped this change when applying since it causes a build break: drivers/clk/samsung/clk.c:338:15: error: variable ‘samsung_clk_syscore_ops’ has initializer but incomplete type drivers/clk/samsung/clk.c:339:2: error: unknown field ‘suspend’ specified in initializer drivers/clk/samsung/clk.c:339:2: warning: excess elements in struct initializer [enabled by default] drivers/clk/samsung/clk.c:339:2: warning: (near initialization for ‘samsung_clk_syscore_ops’) [enabled by default] drivers/clk/samsung/clk.c:340:2: error: unknown field ‘resume’ specified in initializer drivers/clk/samsung/clk.c:340:2: warning: excess elements in struct initializer [enabled by default] drivers/clk/samsung/clk.c:340:2: warning: (near initialization for ‘samsung_clk_syscore_ops’) [enabled by default] CC drivers/dma/virt-dma.o drivers/clk/samsung/clk.c: In function ‘samsung_clk_sleep_init’: drivers/clk/samsung/clk.c:359:3: error: implicit declaration of function ‘register_syscore_ops’ [-Werror=implicit-function-declaration] Please make sure there is no build breaks with various configs when sending patches. -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
