I think it will be more appropriate to add a printk
statement,just to be more informative.
host = scsi_register(template,
> sizeof(scsi_qla_host_t));
> + if (!host){
printk(KERN_WARNING "QLA1280
:Unable to register host\n");
return 0;
}
thanx
--- Rasmus Andersen <[EMAIL PROTECTED]> wrote:
> On Wed, Jan 24, 2001 at 06:59:08AM -0800, rakesh
> rakesh wrote:
> > Hi,
> >
> > This really sounds good.And I think that this
> patch
> > should be applied to qla1280.c driver too.In
> addition
> > to the previous patch regarding request_region.
> >
>
> You are right. I must have missed that one in my
> trawling for
> unchecked scsi_registers in scsi/*. The following
> patch adds
> a check for the return of scsi_register. It applies
> against
> ac10 and 241p9 with and without my earlier patch (a
> bit fuzz
> involved).
>
> Comments?
>
>
> --- linux-ac10/drivers/scsi/qla1280.c~ Wed Jan 24
> 20:59:12 2001
> +++ linux-ac10/drivers/scsi/qla1280.c Wed Jan 24
> 21:00:23 2001
> @@ -810,6 +810,8 @@
> #endif
> /* found a adapter */
> host = scsi_register(template,
> sizeof(scsi_qla_host_t));
> + if (!host)
> + return 0;
> ha = (scsi_qla_host_t *) host->hostdata;
> /* Clear our data area */
> for( j =0, cp = (char *)ha; j <
> sizeof(scsi_qla_host_t); j++)
>
> --
> Regards,
> Rasmus([EMAIL PROTECTED])
>
> A great many people think they are thinking when
> they are merely
> rearranging their prejudices. -- William James
=====
__________________________________________________
Do You Yahoo!?
Yahoo! Auctions - Buy the things you want at great prices.
http://auctions.yahoo.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
