I tested your patch and it has no adverse effects on my development system. If there is a general consensus about the call order from the hot-plug/pci people, I'll include it in my next EATA driver revision. Cheers, -db -----Original Message----- From: Rasmus Andersen [mailto:[EMAIL PROTECTED]] Sent: Monday, January 29, 2001 10:54 PM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [uPATCH] make drivers/scsi/eata.c call pci_enable_device before rs. probing (241p11) Hi. The following patch makes drivers/scsi/eata.c wait with probing pci resources until we have called pci_enable_device. This is recommended due to hot-plug considerations (according to Jeff Garzik). It applies against ac12 and 241p11. Comments? --- linux-ac12-clean/drivers/scsi/eata.c Tue Nov 28 02:49:00 2000 +++ linux-ac12/drivers/scsi/eata.c Sat Jan 27 21:24:20 2001 @@ -835,9 +835,9 @@ if (!(dev = pci_find_class(PCI_CLASS_STORAGE_SCSI << 8, dev))) break; - addr = pci_resource_start (dev, 0); - if (pci_enable_device (dev)) continue; + + addr = pci_resource_start (dev, 0); #if defined(DEBUG_PCI_DETECT) printk("%s: tune_pci_port, bus %d, devfn 0x%x, addr 0x%x.\n", -- Regards, Rasmus([EMAIL PROTECTED]) While the Melissa license is a bit unclear, Melissa aggressively encourages free distribution of its source code. -- Kevin Dalley on Melissa being Open Source - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED]
