On Sat, Feb 10 2001, Justin T. Gibbs wrote:
> >Well the driver isnt allowed to hold interrupts off for > 1 tick because
> >that messes up the clock, and at 1 second the watchdog nmi will reboot
> >
> >scsi driver authors therefore need to adjust their drivers
>
> If you ask me, it is a bug that the io_request lock is forced on low
> level drivers at all. 90% of the aic7xxx driver pretends that the
> io_request_lock doesn't exist, relying instead on a per-controller instance
> lock. The interrupt handler only aquires the io_request lock for calls back
> into the mid-layer as it is expected to be held (although the mid-layer
> almost instantly releases it again). I also immediately release the
> io_request_lock in all of my error recovery entry points because I don't
> need the protection and, as you say, we can't lock up the system while we're
> waiting for recovery actions to complete.
You are doing the Right Thing, the io_request_lock will die in the
next devel series. And no doubt the hardest part of that is not the
actual i/o layers, it's the SCSI low level drivers that do all sorts
of funnies with it.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
