On Tue, Feb 13, 2001 at 09:40:36AM -0500, Douglas Gilbert <[EMAIL PROTECTED]> wrote:
> Daniel Eisenbud wrote:
> >
> > Eight different SCSI drivers have large switch statements to determine
> > the direction in which data will be transferred for a given SCSI
> > command. I discovered this when trying to figure out why the MESH
> > (powermac SCSI) driver locked up when (and only when) trying to burn a
> > CD-R in disk-at-once mode. It turns out that there's a command that's
> > not in any of these tables (cdrecord refers to it as send_cue_sheet) and
> > it's absence is enough to kill the MESH driver (and apparently also the
> > mac53c94 driver.)
>
> Daniel,
> Does that driver take any account of Scsi_Cmnd::sc_data_direction_flag?
> All upper level drivers (including sg) in the lk 2.4 series set
> the corresponding Scsi_Request::sr_data_direction_flag .
[...]
The driver appears not to use sc_data_directon_flag yet. I will look
into making it do so (and the other drivers in question too, possibly,
though I have no way of testing any but mesh.c and mac53c94.c).
> Data direction tables shouldn't be needed in lk 2.4 .
Great!
As for 2.2, would the equivalent of the patch that I sent be acceptable
for inclusion? If that's too big a change, what about a patch that just
adds SEND_CUE_SHEET to include/scsi/scsi.h and each of the case
statements in the drivers in question?
-Daniel
--
Daniel E. Eisenbud
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
