Hi. I've been browsing the scsi sources, looking for a definition of the return data struct from the INQUIRY command (since I need it in a USB/ATAPI driver I'm working on and I didn't want to reinvent the wheel). I was rather surprised to find no such structure "publicly" defined anywhere. Instead I found it duplicated in a number of vendor-specific drivers. Examples: BusLogic.h: SCSI_Inquiry_T gdth.h: gdth_inq_data ips.h: IPS_INQ_DATA osst.h: idetape_inquiry_result_t pci2000.h: INQUIRYDATA pluto.h: pluto_inquiry psi240i.h: INQUIRYDATA psi_dale.h: INQUIRYDATA tmscsim.h: SCSI_INQDATA All of them look the same, although some use bitfields and some don't. It's got my fingers itching: - Wouldn't it be a good idea to concentrate standard scsi symbols like this to a single file, just like the command numbers are in include/scsi/scsi.h? Yes, the formats differ between SCSI-1, -2 and -3 but they are still compatible (at least INQUIRY is). - If I were to produce a patch for this, would it be welcomed or frowned upon? Should I produce one patch per driver, or a single big one? /Björn - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED]
