On Wed, 2005-02-02 at 18:08 -0800, Andrew Morton wrote: > "erich" <[EMAIL PROTECTED]> wrote: > > > > I have contact with Andrew Morton about ARECA RAID Linux scsi driver release > > issue. > > I hope this package is as look like a Linux driver. > > No, it doesn't look anything like a Linux driver :( > > I fed the patch through scripts/Lindent. There's a copy at > http://www.zip.com.au/~akpm/linux/patches/stuff/areca-raid-linux-scsi-driver.patch. > I'll include it -mm kernels. > > >From a very quick look, I'd say that the driver needs quite a bit of work:
It is nice to see vendors submitting drivers for their hardware; this one does need some more work though to look like a linux driver more work items: * needs to use list.h lists not open coded ones * uses wrong locking for the scsi layer (eg ->done should be called without locks) * ULONG and simliar typedefs.. does this driver come from windows ? typedef uint32_t ULONG, *PULONG; is just not a good idea. * lots and lots of ifdefs that are done wrongly; eg if you need to do version ifdefs.. do them right ;( example: arcmsr_doInterrupt() is ifdefd needlessly/wrongly - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
