On Tue, 08 Feb 2005, Patrick Mansfield wrote:
> I'm still getting lots of BUG's for the smp_processor_id, but via the
> interrupt function.
>
It's during the driver's init-time polling for interrupts...
> I am running the latest bk, it has your patch to qla_os.c:
>
> [elm3b79 qla2xxx]$ grep smp_proc qla_os.c
> if (_smp_processor_id() == ha->last_irq_cpu || was_empty)
>
> I'm running on a NUMAQ (sometimes has funky latencies). There are no
> errors for simple IO (dd if=/dev/sda of=/dev/null bs=64k). There are about
> 40 disk drives attached.
>
Argg -- that was careless... Again, the smp_processor_id() is used
only as a heuristic. The attached patch should quash the noise.
Thanks.
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]>
===== drivers/scsi/qla2xxx/qla_isr.c 1.23 vs edited =====
--- 1.23/drivers/scsi/qla2xxx/qla_isr.c 2005-02-04 10:24:27 -08:00
+++ edited/drivers/scsi/qla2xxx/qla_isr.c 2005-02-08 22:41:08 -08:00
@@ -91,7 +91,7 @@
}
spin_unlock_irqrestore(&ha->hardware_lock, flags);
- ha->last_irq_cpu = smp_processor_id();
+ ha->last_irq_cpu = _smp_processor_id();
ha->total_isr_cnt++;
if (test_bit(MBX_INTR_WAIT, &ha->mbx_cmd_flags) &&
@@ -200,7 +200,7 @@
}
spin_unlock_irqrestore(&ha->hardware_lock, flags);
- ha->last_irq_cpu = smp_processor_id();
+ ha->last_irq_cpu = _smp_processor_id();
ha->total_isr_cnt++;
if (test_bit(MBX_INTR_WAIT, &ha->mbx_cmd_flags) &&
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
