Am Montag, 14. Februar 2005 12:09 schrieb Christoph Hellwig: > On Mon, Feb 14, 2005 at 11:57:29AM +0100, Rolf Eike Beer wrote: > > Hi, > > > > this patch removes some useless struct declarations from > > drivers/scsi/scsi.h. All this structs are already defined in the header > > files included above except Scsi_Host, for which we now directly include > > <scsi/scsi_host.h> > > No, this is totally wrong. If you only use pointers to structs always > use forward declarations instead of pulling in a full header.
Ok, this time without include scsi/scsi_host.h. The rest remains untouched, "struct Scsi_Host;" is also in scsi/scsi_device.h. The header files for all other structs are already included so no need do declare them again. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.10/drivers/scsi/scsi.h 2004-12-24 22:34:27.000000000 +0100 +++ linux-2.6.10/drivers/scsi/scsi.h-new 2005-02-14 11:45:54.000000000 +0100 @@ -40,12 +40,6 @@ #define FALSE 0 #endif -struct Scsi_Host; -struct scsi_cmnd; -struct scsi_device; -struct scsi_target; -struct scatterlist; - /* * Legacy dma direction interfaces. * - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
