On Thu, 2005-02-17 at 12:34 -0500, Luben Tuikov wrote: > Adaptec would like to announce its SAS/SATA Linux device driver > for inclusion into the Linux kernel.
Well, the initial reaction is yuk. Just from a brief glance over the files, the code is full of obfuscation and unnecessary compatibility gunk which needs removing. It's also full of the same queueing junk that I asked be taken out of the aic7xxx driver. Then we get to the architectural stuff, which should really have been discussed before you wrote the driver, not after - We need a SAS and a PHY transport class. Three of your files are to do domain discover and should actually be part of the SAS transport class. In fact, it looks like a large amount of the code should be in the various transport classes. - The SATA pieces should use libata instead of trying to reinvent what already exists. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
