In the diff >+ if (old_hdr) >+ kfree(old_hdr); >+ return retval;
The check for NULL is not needed. Thanks, Rayan On Mon, 28 Mar 2005 19:48:10 +1000, Douglas Gilbert <[EMAIL PROTECTED]> wrote: > The attachment combines the most recent patch from > Yum Rayan <[EMAIL PROTECTED]> (to reduce sg stack > usage), Adrian Bunk <[EMAIL PROTECTED]> (to fix check > after use) and me (fix elapsed time calculation > (duration) on ia64 machines). > > I have modified the patch from Yum Rayan so kmalloc() > in sg_read() is only called for the (rare) code paths > that need them. > > Changelog: > - reduce stack usage in sg_ioctl() and sg_read() > - fix check after use in sg_mmap() > - hold duration internally in milliseconds and > check current time later than held time > > Signed-off-by: Douglas Gilbert <[EMAIL PROTECTED]> > > > - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
