On Mon, 2005-03-28 at 22:59 +0100, Christoph Hellwig wrote: > On Mon, Mar 21, 2005 at 10:41:23AM -0800, Mark Haverkamp wrote: > > A patch from Adaptec with byte order changes: > > - drop byte swapping on all 0's and all 1's content > > - fix up missing swapping directives > > - ensure swapping on 16 bit values does not use 32 bit swap > > - reconcile the readl/writel auto-swapping in only most of the > > configurations. > > that last bit is bogus. readl/writel are defined to swap bytes on > big endian systems. Whatever broken Mvista/Windriver or whatever port > doesn't do that should be fixed. > > Also please remove unrelated changes like the new cardtypes from the patch, > follow normal kernel codingstyle (e.g. ||, && at the end of the line) and > switch to __le* types for harware structures and make sure it's passing > sparse -Wbitwise.
I ran sparse on the driver and without the -Wbitwise, it only has 7 warnings such as: CHECK drivers/scsi/aacraid/linit.c drivers/scsi/aacraid/linit.c:218:12: warning: symbol 'aac_info' was not declared. Should it be static? With -Wbitwise there are about 200 warnings of this sort: drivers/scsi/aacraid/aachba.c:180:18: warning: incorrect type in assignment (different base types) drivers/scsi/aacraid/aachba.c:180:18: expected unsigned int [unsigned] [usertype] command drivers/scsi/aacraid/aachba.c:180:18: got restricted unsigned int [usertype] [force] <noident> What is your preference, I could clean up the existing patch and re- submit and then address the sparse warnings with a follow-up patch. Or try to fix everything in one patch. Thanks, Mark. -- Mark Haverkamp <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
