Suitable for both 2.4 and 2.6 version of the driver. Applies to
scsi-misc-2.6 git tree.

Prevent driver from loading if another driver (i2o) has already claimed
the resources associated with the card. Discussion associated with this
bug can be referenced at http://bugzilla.kernel.org/show_bug.cgi?id=4940
where it was agreed to use pci_request_regions in both the dpt_i2o and
the i2o driver to prevent both drivers loading on the same adapter(s).

Signed-off-by: Mark Salyzyn <[EMAIL PROTECTED]>

Index: a/drivers/scsi/dpt_i2o.c
===================================================================
--- a/drivers/scsi/dpt_i2o.c    2005-07-26 11:42:03.000000000 -0400
+++ b/drivers/scsi/dpt_i2o.c    2005-08-08 09:50:33.247595544 -0400
@@ -908,8 +908,12 @@
        }
 
-
+       if (pci_request_regions(pDev)) {
+               PERROR("dpti: adpt_config_hba: pci request region
failed\n");
+               return -EINVAL;
+       }
        base_addr_virt = ioremap(base_addr0_phys,hba_map0_area_size);
        if (!base_addr_virt) {
+               pci_release_regions(pDev);
                PERROR("dpti: adpt_config_hba: io remap failed\n");
                return -EINVAL;
        }
@@ -919,6 +924,7 @@
                if (!msg_addr_virt) {
                        PERROR("dpti: adpt_config_hba: io remap failed
on BAR1\n");
                        iounmap(base_addr_virt);
+                       pci_release_regions(pDev);
                        return -EINVAL;
                }
        } else {
@@ -932,6 +938,7 @@
                        iounmap(msg_addr_virt);
                }
                iounmap(base_addr_virt);
+               pci_release_regions(pDev);
                return -ENOMEM;
        }
        memset(pHba, 0, sizeof(adpt_hba));
@@ -1027,6 +1034,7 @@
        up(&adpt_configuration_lock);
 
        iounmap(pHba->base_addr_virt);
+       pci_release_regions(pHba->pDev);
        if(pHba->msg_addr_virt != pHba->base_addr_virt){
                iounmap(pHba->msg_addr_virt);
        }

Sincerely -- Mark Salyzyn
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to