On 5/8/07, Christof Schmitt <[EMAIL PROTECTED]> wrote:
On Tue, May 08, 2007 at 01:56:07AM +1000, Julian Calaby wrote: > >From: Christof Schmitt <[EMAIL PROTECTED]> > [snip] > >- ZFCP_LOG_NORMAL("bug: unexpected inbound " > >- "packet on adapter %s " > >- "(reqid=0x%lx, " > >- "first_element=%d, " > >- "elements_processed=%d)\n", [...] > As a minor quibble, may I suggest that these lines belong just above > the panic introduced above? I assume that they'd be useful for > debugging should this situation occur.If this problem occurs, the administrator of the Linux system will be advised to dump the Linux system and to also capture the logs from the FCP adapter. The memory dump already contains the information about the unexpected packet and also information about the last requests sent to the FCP adapter. So, the messages do not provide additional debug data, and i removed them to simplify the code.
Ah! Thanks, -- Julian Calaby Email: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
