FUJITA Tomonori wrote:
> +#define scsi_for_each_sg(cmd, sg, nseg, __i)                 \
> +     for (__i = 0, sg = scsi_sglist(cmd); __i < (nseg); __i++, (sg)++)
> +

This feels like a layering violation, why not use for_each_sg()?

+#define scsi_for_each_sg(cmd, sg, nseg, __i)                   \
        for_each_sg(scsi_sglist(cmd), (sg), (nseg), (__i))      \

That said, I'm not sure that scsi_for_each_sg() is worth abstracting
since the caller can just as well do for_each_sg() directly
as sketched above...

Benny
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to