On Mon, 2007-05-07 at 14:57 -0400, James Smart wrote:
> +       mutex_lock(&shost->scan_mutex);
>         scsi_sysfs_add_devices(shost);
> +       atomic_set(&shost->async_scan, 0);
> +       mutex_unlock(&shost->scan_mutex);

It really seems that the only safety here is expanding the scan mutex to
cover more of the code.  I don't really see any value to using the
atomic types ... it's not a simultaneous variable update problem, it's a
scan race which the mutex can be used to mediate.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to