On Tue, Jun 12, 2007 at 10:54:36AM +0530, vignesh babu wrote:
> @@ -1651,7 +1652,7 @@ static inline int reconnect_target(struct NCR_ESP *esp,
> struct ESP_regs *eregs)
> if(!(it & me))
> return -1;
> it &= ~me;
> - if(it & (it - 1))
> + if(!is_power_of_2(it))
> return -1;
> while(!(it & 1))
> targ++, it >>= 1;
I think you actually want to do:
- if(!(it & me))
- return -1;
it &= ~me;
- if(it & (it - 1))
+ if (!is_power_of_2(it))
return -1;
as it looks to me like the first test is checking for the n != 0 case in
is_power_of_two().
Not that it'll matter much -- AIUI, this driver is scheduled for
deletion soon.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
