Also, general comment:

To be, or not to be:  CONFIG_PCI and CONFIG_EISA

Even with !CONFIG_FOO handling in the relevant header file, you still wind up with dead code being built into the driver. The !CONFIG_FOO behavior remains correct (a no-op), of course.

I don't have an opinion either way. On one hand, the present setup is clean. On the other hand, you are likely to run into non-ISA platforms that might not be happy with building non-PCI code. It's not the eisa_register_driver() that is the problem, but other ISA-specific functions you wind up using in the process.

Plus, Andi likes to make a big fuss about building ISA code on x86-64 :)

        Jeff





-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to