On Fri, Jul 27, 2007 at 11:53:46AM -0400, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> >I still say it's an improvement over scanning the list of scsi hosts
> >looking for any that have work pending whenever any interrupt comes in.
> 
> Having the kernel interrupt subsystem implement a loop for you is 
> completely utterly unusual, slow, silly, and likely to get broken when 
> people futz with the interrupt system core.  It probably has edge cases 
> too, like screwing with the screaming interrupt detection code.
> 
> The kernel interrupt subsystem is not meant to be abused in that way.

I think what you're missing is: This isn't new.  The advansys driver
was *already* requesting the same interrupt twice for EISA boards.
It's just that before, when an interrupt happened on the EISA board,
it would scan all Scsi_Hosts twice, and now it scans this pair of boards
once each.

It may not be elegant, it may not be the best way, but it *is* a
monotonic improvement.  So please, calm down.

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to